-
Notifications
You must be signed in to change notification settings - Fork 10k
feat(acp): add session usage #12299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(acp): add session usage #12299
+121
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Edit: fixed now! |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This commit adds support for the unstable usage reporting over ACP: https://agentclientprotocol.com/rfds/session-usage I decided to always calculate the totals on each message, but we could also decide to keep this as extra state for an ACP session, so we only need to look at the sdk response for the most recent message.
bb118fe to
d615ecc
Compare
Collaborator
|
/review |
Contributor
|
lgtm |
kyashrathore
pushed a commit
to kyashrathore/Claxedo
that referenced
this pull request
Feb 7, 2026
Co-authored-by: Aiden Cline <[email protected]>
kyashrathore
pushed a commit
to kyashrathore/Claxedo
that referenced
this pull request
Feb 8, 2026
Co-authored-by: Aiden Cline <[email protected]>
fanjia1024
pushed a commit
to fanjia1024/opencode
that referenced
this pull request
Feb 10, 2026
Co-authored-by: Aiden Cline <[email protected]>
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Feb 13, 2026
Co-authored-by: Aiden Cline <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the unstable usage reporting over ACP: https://agentclientprotocol.com/rfds/session-usage
I decided to always calculate the totals on each message, but we could also decide to keep this as extra state for an ACP session, so we only need to look at the sdk response for the most recent message.
Closes #12298.
How did you verify your code works?
I verified this with Tidewave, which shows usage information in the UI if supported by the ACP agent.